Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add blur on enter on omni-text-field component #211

Merged

Conversation

chromaticWaster
Copy link
Contributor

@chromaticWaster chromaticWaster commented Nov 20, 2023

Description:

closes #179

Issue raised on mobile application using the omni-text-field component.

Note this issue will not occur on more modern devices as these devices will have a "next" button which will focus the next input component vs a "enter" button.

Screenshots (if appropriate):

image

For the testing of this use case it was done using developer tools in the chrome browser this is not close to a real world scenario although the issue can be demonstrated

Values are typed in a the omni-text-field component and then the enter key is pressed on the keyboard.

Before

Screen.Recording.2023-11-20.at.13.50.53.mov

After

Screen.Recording.2023-11-20.at.13.53.11.mov

IPhone Tests

Before

IPhoneBefore.mov

After

IphoneAfter.mov

All Submissions:

Changes to Core Features:

  • I have added an explanation of what my changes do and why I would like to include them.
  • I have written new tests for my core changes, as applicable.
  • I have successfully ran tests with my changes locally.
  • I have added/updated docs, as applicable.

@chromaticWaster chromaticWaster linked an issue Nov 20, 2023 that may be closed by this pull request
2 tasks
@chromaticWaster chromaticWaster changed the title Initial implementation Bug: Add blur on enter on omni-text-field component Nov 21, 2023
@chromaticWaster chromaticWaster marked this pull request as ready for review November 23, 2023 06:57
@chromaticWaster chromaticWaster self-assigned this Nov 23, 2023
@stefan505 stefan505 changed the title Bug: Add blur on enter on omni-text-field component Bug: Add blur on enter on omni-text-field component Nov 23, 2023
@stefan505 stefan505 merged commit 7f939e6 into develop Nov 23, 2023
7 checks passed
@stefan505 stefan505 deleted the Bug-add-blur-on-enter-functionality-to-text-field-component branch November 23, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Add blur on enter functionality to text field component
3 participants